vagrant-hostmanager and gem install nokogiri #15
Conversation
… OSX to README.md.
|
Thanks, @zendoodles! Could you just add a "Troubleshooting" section at the bottom and put this note there? |
A number of folks running older versions of vagrant experienced issues getting nokogiri installed due to a bug that was fixed in vagrant version 1.7.2: hashicorp/vagrant#3769 We shouldn't support older versions of Vagrant due to these issues.
|
Mathew, we've changed the version dependency for vagrant and added some troubleshooting documentation. There are no functional changes in this PR, just documentation changes. Can you review and merge? |
|
|
||
| ...and `gem install nokogiri -v '1.6.6.2'` does not resolve the problem, try `gem install nokogiri -v '1.6.6.2' -- --use-system-libraries --with-iconv-dir=/usr/local/Cellar/libiconv/1.14 --with-xml2-include=/usr/include/libxml2 --with-xml2-lib=/usr/lib/` | ||
|
|
||
| @see https://github.com/sparklemotion/nokogiri/issues/1166 for details. | ||
|
|
There was a problem hiding this comment.
I'm concerned that this is trying to solve the wrong problem- the issue (as far as I understand) is vagrant. If you look at this thread: hashicorp/vagrant#3769 the issue seems to be versions of vagrant before 1.7.2 Are the instances where this problem has shown up on vagrant versions < 1.7.2?
There was a problem hiding this comment.
I'm not aware of anyone using Vagrant version 1.7.2 or greater that has had this issue. That's why this PR also updates the version requirement. Should we remove this troubleshooting information?
(If you think we should, I'd be more comfortable opening a new PR and just deleting this branch, since it's @zendoodles's branch and this was her change.)
There was a problem hiding this comment.
Given that this issue seems to be with earlier versions of vagrant, I'd prefer that the text say something about "if you're getting nokogiri install issues, ensure that your vagrant version is..."
There was a problem hiding this comment.
@arthur24b6 I believe the real issue (aside from the issue you mentioned) is that the latest nokogiri version is incompatible w/ vagrant 1.6.x
Almost everyone that I've helped through this was able to upgrade vagrant to overcome these nokogiri issues.
With all that being said, these notes do not belong in this repository. @Crell has opened the PR palantirnet/development_documentation#31 to have a central place to communicate these issues.
There was a problem hiding this comment.
We can also enforce a minimum vagrant version.
|
@mathewpeterson pinging you on this. I think it is ready to merge now, but appreciate your review. |
|
This has to be rebased. |
| @@ -1,3 +1,5 @@ | |||
| Vagrant.require_version ">= 1.7.2" | |||
|
👍 |
vagrant-hostmanager and gem install nokogiri
Add notes about issues installing vagrant-hostmanager and nokogiri on OSX to README.md.