Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chunk_map_feature() #159

Merged
merged 2 commits into from
Oct 9, 2022
Merged

Remove chunk_map_feature() #159

merged 2 commits into from
Oct 9, 2022

Conversation

paleolimbot
Copy link
Owner

Fixes #132. This is a hard pattern to generalize...the chunk strategies are useful but implementations should almost certainly always be doing their own looping.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Base: 99.04% // Head: 99.03% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0fa5d06) compared to base (7b34393).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   99.04%   99.03%   -0.01%     
==========================================
  Files          81       81              
  Lines        5875     5824      -51     
==========================================
- Hits         5819     5768      -51     
  Misses         56       56              
Impacted Files Coverage Δ
R/chunk.R 96.42% <ø> (-1.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paleolimbot paleolimbot merged commit 7c86afb into master Oct 9, 2022
@paleolimbot paleolimbot deleted the remove-chunk-map-feat branch October 9, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chunk_map_feature should not copy chunks if input_handler_factory = NULL
2 participants