add wk_trans_explicit()

[mdsumner]

as advised in #185 this migrates the base part of trans_explicit from crs2crs

• migrate code from crs2crs
• create wk_coords()<-
• make sure use_z use_m are working for replacement function wk_coords
• fix up doc, e.g. it's not "in-place" exactly
• outline examples
• tests
• unsure how to structure the doc, getting code/doc order mismatch in wk_coords ...
• worry about leaving objects in a bad state (e.g. not updating the crs)

(it's actually amazing, I think I was confused about what it did in previous times)

[mdsumner]

questions/discussion

• the doc for crs_trans_explicit says "A vector of coordinates as a [wk::xy()] used to replace" but it can actually be any handleable with the same coordinate structure - not a big deal just wondered if I was missing anything becauce the wk_coords<- and wk_trans_explicit doc is now a bit inconsistent

[paleolimbot]

Thank you! This is looking good!

worry about leaving objects in a bad state (e.g. not updating the crs)

I think wk_transform() takes care of this and strips the CRS for anything it returns. You could always add a test of wk_coords(wkt("POINT (0 1)", crs = "EPSG:1234")) <- xy(1, 2) to find out.

it can actually be any handleable with the same coordinate structure

It seems like any non-point replacement will fail at as_xy()?

unsure how to structure the doc, getting code/doc order mismatch in wk_coords ...

I think it's because both wk_trans_explicit() and wk_coords() define value. You could try removing @param value from wk_coords() or if that doesn't work, rename value in wk_trans_explicit()?

[mdsumner]

thanks! I'm getting back to this

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7c1f504) 99.03% compared to head (c88225f) 99.03%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master     #187    +/-   ##
========================================
  Coverage   99.03%   99.03%            
========================================
  Files          81       85     +4     
  Lines        5918     6035   +117     
========================================
+ Hits         5861     5977   +116     
- Misses         57       58     +1     

Files Changed	Coverage Δ
src/init.c	100.00% <ø> (ø)
R/trans-explicit.R	100.00% <100.00%> (ø)
R/vertex-filter.R	100.00% <100.00%> (ø)
src/trans-explicit.c	100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mdsumner]

I got it! as explained in https://adv-r.hadley.nz/functions.html#replacement-functions it has to be function(object, <other arguments>, value)

[paleolimbot]

Thank you for taking this on and polishing! I'm on vacation with a 2 and 3 year old and will take a close look + merge when I'm back!

[paleolimbot]

Sorry this took me so long to get to! I did a few minor shuffles but the code looks great!