Merge pull request #51 from palfrey/update-for-newer-warnings

Update for latest rust/actions

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
           - beta
           - nightly
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: true
       - uses: dtolnay/rust-toolchain@master
@@ -40,7 +40,7 @@ jobs:
     name: minimal versions check
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: true
       - uses: dtolnay/rust-toolchain@master
@@ -55,7 +55,7 @@ jobs:
     name: web build
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: true
       - uses: dtolnay/rust-toolchain@master
@@ -75,13 +75,12 @@ jobs:
     needs: [web, test, minimal-versions]
     if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: true
       - uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
-          override: true
           target: wasm32-unknown-unknown
       - uses: Swatinem/rust-cache@v2
       - name: Install trunk

src/runner.rs

@@ -68,11 +68,11 @@ fn run_binop_shortcut(
     shortcut_return: bool,
     f: fn(&State, &Expression, &Expression) -> Result<bool>,
 ) -> Result<bool> {
-    let res_first = run_expression(state, program, first.deref())?;
+    let res_first = run_expression(state, program, first)?;
     if shortcut.is_some() && shortcut.unwrap() == res_first {
         return Ok(shortcut_return);
     }
-    let res_second = run_expression(state, program, second.deref())?;
+    let res_second = run_expression(state, program, second)?;
     debug!("first: {:?} second: {:?}", res_first, res_second);
 
     // Check for same types comparison first
@@ -143,8 +143,8 @@ fn run_mathbinop(
     op: &Expression,
     f: fn(f64, f64) -> f64,
 ) -> Result<Expression> {
-    let res_first = run_expression(state, program, first.deref())?;
-    let res_second = run_expression(state, program, second.deref())?;
+    let res_first = run_expression(state, program, first)?;
+    let res_second = run_expression(state, program, second)?;
     match res_first {
         Expression::Floating(ref i) => {
             let first_value = *i;