Define Rails.configuration.event_store after initialization #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates ActiveEventStore to define Rails.configuration.event_store after the event store has been initialized. Fixes palkan#17
|
Any idea what is wrong with sqlite on the 3.0, 3.1, and 3.2 builds? Guessing it is related to the tests using the 2.X release 3.0+, since it doesn't run on Ruby 2.7. Edit: Figured it out, looks like active record pinned it to |
palkan
force-pushed
the
master
branch
3 times, most recently
from
8895b41 to
8c6f78e
Compare
|
Looks good 👍 Thanks! P.S. I fixed the sqlite/Rails 8 problems in master; should be green after the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates ActiveEventStore to define Rails.configuration.event_store after the event store has been initialized. Fixes #17
What is the purpose of this pull request?
Defines
Rails.configuration.event_storeafter the event store is initialized, so that the rails event store browser tools (and other tools) should ideally just work out of the box. Fixes #17Checklist