-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename .titan extension and directory titan-compiler #36
Conversation
Thanks for showing interest in helping us with this issue. Please let us know if you need assistance in getting the test suite to run on your machine. It has a shorter feedback loop than Travis :) |
That'd be great, yeah. I really wanna know why this keeps failing. |
luarocks install --local --only-deps pallene-dev-1.rockspec
make linux-readline # for linux
make macosx # for macos
# running the compiler
./pallenec foo.pallene
./lua/src/lua -l foo
luarocks install --local busted
busted # run all tests
busted spec/parser_spec.lua # run just one of the test files Please let me know if this works for you or not. If it does, I'll fix our README file to use these instructions. BTW, you don't need to close and reopen this PR all the time. Travis already informs us when the PR is broken and needs to be fixed so you don't need to do that yourself. |
Thanks! I got this pull working but I'll definitely use that for my future contributions :D |
I ran this PR locally and noticed that there are some problems that were not caught by the test suite. Could you please try fixing them?
|
Sure thing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the help! I think we need just a pair of small changes before merging this PR:
- Fix the comments on driver.lua, as per previous comment
- Replace "titan" with "pallene" in the
.editorconfig
file.
pallene/driver.lua
Outdated
-- compile("titan", "so", "foo.titan") --> outputs "foo.so" | ||
-- compile("titan", "c", "foo.titan") --> outputs "foo.c" | ||
-- compile("titan", "so", "foo.pallene") --> outputs "foo.so" | ||
-- compile("titan", "c", "foo.pallene") --> outputs "foo.c" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to become compile("pallene", "so", "foo.pallene")
and compile("pallene", "c", "foo.pallene")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, will do.
Think I got them all. |
Thanks! By the way, have you tried running the test suite on your side? I'm rewriting the README right now so I'd love if you could confirm if the instructions worked. |
As per the 3rd and 4th objective of Issue #22