Optional function arguments #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we consider rightmost "any" arguments to be optional. In the future we could consider requiring that the programmer annotate optional arguments with "?", and also allow things like "string?". Dynamic Lua calls now can have a variable number of stack arguments.
Lua's math.log has an optional second parameter for the base, with the default being the natural logarithm. Previously, Pallene didn't have optional arguments so we needed a separate function for 1-argument math.log. Now that's no longer necessary :) I have checked the generated assembly and can confirm that the C compiler can inline the pallene_math_log and directly call log() from math.h when the base argument is known.
singul4ri7y
reviewed
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Pallene functions to receive optional arguments. Currently any rightmost "any" argument can be optional. In the future we may want to consider a special optional type, for added type safety.
This change allows us to get rid of the
math.lnhack. Good riddance!