Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspect.getargspec() is deprecated, use inspect.signature() or inspect.getfullargspec() #94

Closed
krassowski opened this issue Jan 11, 2019 · 1 comment
Closed

inspect.getargspec() is deprecated, use inspect.signature() or inspect.getfullargspec() #94

krassowski opened this issue Jan 11, 2019 · 1 comment
Assignees
@hoatle
Labels
prio:major reso:fixed tag:unplanned type:improvement
Milestone
v0.15.0-b1-flask-c

Comments

@krassowski
Copy link

Hi @hoatle, thank you for maintaining flask-classful!

After migration to Python3.7 I am being flooded with deprecation warning - could you have a look at it?

virtualenv/python3.7.1/lib/python3.7/site-packages/flask_classful.py:382: DeprecationWarning:
inspect.getargspec() is deprecated, use inspect.signature() or inspect.getfullargspec()

It might be that simple swapping of the order of this try-except would fix it:
https://github.com/teracyhq/flask-classful/blob/42fa5fce1fa97b1f00813b4ce0dd13ebebdb28cc/flask_classful.py#L446-L449
@hoatle hoatle self-assigned this Jan 12, 2019
@hoatle hoatle added this to the v0.15.0-flask-c milestone Jan 12, 2019
@hoatle
Copy link
Contributor

hoatle commented Jan 12, 2019

thank you @krassowski, this will be fixed by the next release.

hoatle added a commit to hoatle/flask-classful that referenced this issue Jan 12, 2019
@hoatle
@ pallets-eco#94 | inspect.getargspec() is deprecated, use inspect.si…
3159078 
…gnature() or inspect.getfullargspec()
@hoatle hoatle mentioned this issue Jan 12, 2019
Merged
hoatle added a commit that referenced this issue Jan 12, 2019
@hoatle
Merge pull request #95 from hoatle/improvements/#94-deprecated-messag…
f983cba 
…es-removal

@ #94 | inspect.getargspec() is deprecated, use inspect.signature() or inspect.getfullargspec()
@hoatle hoatle closed this as completed Jan 12, 2019
@ghost ghost removed the stag:under-review label Jan 12, 2019
@hoatle hoatle mentioned this issue Jan 17, 2019
Closed
hoatle added a commit to hoatle/flask-classful that referenced this issue Jan 23, 2019
@hoatle
@ pallets-eco#94 | inspect.getargspec() is deprecated, use inspect.si…
cfb4d4a 
…gnature() or inspect.getfullargspec()
hoatle added a commit to hoatle/flask-classful that referenced this issue Jan 23, 2019
@hoatle
@ pallets-eco#94 | inspect.getargspec() is deprecated, use inspect.si…
0e688b9 
…gnature() or inspect.getfullargspec()
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hoatle hoatle

Labels
prio:major reso:fixed tag:unplanned type:improvement
Milestone
v0.15.0-b1-flask-c
Development

No branches or pull requests
2 participants
@hoatle @krassowski