Fix datetime_factory as attribute. (#960)

datetime_factory should still be set as an attribute - that got lost. Also - trackable didn't use the attribute - it directly referenced the config value - fix that.

Add a test.

close #959

CHANGES.rst

@@ -13,6 +13,7 @@ Fixes
 - (:issue:`950`) Regression - some templates no longer getting correct config (thanks pete7863).
 - (:issue:`954`) CSRF not properly ignored for application forms using SECURITY_CSRF_PROTECT_MECHANISMS.
 - (:pr:`957`) Improve jp translations (e-goto)
+- (:issue:`959`) Regression - datetime_factory should still be an attribute (thanks TimotheeJeannin)
 
 Version 5.4.2
 -------------

flask_security/core.py

@@ -1387,6 +1387,7 @@ def init_app(
             "render_template",
             "totp_cls",
             "webauthn_util_cls",
+            "datetime_factory",
         ]
         for attr in attr_names:
             if ov := kwargs.get(attr, cv(attr.upper(), app, strict=False)):

flask_security/utils.py

@@ -188,7 +188,7 @@ def login_user(
 
         old_current_login, new_current_login = (
             user.current_login_at,
-            config_value("DATETIME_FACTORY")(),
+            _security.datetime_factory(),
         )
         old_current_ip, new_current_ip = user.current_login_ip, remote_addr
 

tests/test_trackable.py

@@ -5,6 +5,7 @@
     Trackable tests
 """
 
+import datetime
 import pytest
 from flask import after_this_request, redirect
 from werkzeug.middleware.proxy_fix import ProxyFix
@@ -92,3 +93,15 @@ def save_user(response):
         assert user.last_login_ip == _client_ip(client)
         assert user.current_login_ip == "127.0.0.1"
         assert user.login_count == 2
+
+
+@pytest.mark.settings(datetime_factory=lambda: datetime.datetime(2024, 3, 24))
+def test_trackable_datetime(app, client):
+    app.wsgi_app = ProxyFix(app.wsgi_app, x_for=1)
+    e = "matt@lp.com"
+    authenticate(client, email=e)
+
+    with app.app_context():
+        user = app.security.datastore.find_user(email=e)
+        assert user.current_login_at == datetime.datetime(2024, 3, 24)
+        assert user.login_count == 1