Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datastore support for new flask-sqlalchemy-lite #989

Closed
jwag956 opened this issue Jun 11, 2024 · 2 comments · Fixed by #994
Closed

Add datastore support for new flask-sqlalchemy-lite #989

jwag956 opened this issue Jun 11, 2024 · 2 comments · Fixed by #994

Comments

@jwag956
Copy link
Collaborator

jwag956 commented Jun 11, 2024

No description provided.

@peterkronenberg
Copy link

Hi, you answered a question of mine on StackOverflow, https://stackoverflow.com/questions/78675096/how-to-prevent-flask-security-from-using-db-session-query-property/78678324#78678324.
Any thoughts on when this support will be done. I decided to take the plunge and move to Flask-SQLAlchemy-Lite

I posted another question which was closed, https://stackoverflow.com/questions/78678498/sqlalchemy-vs-flask-alechemy, although I'd love to hear your thoughts (I know this isn't really the right place for this)

@jwag956
Copy link
Collaborator Author

jwag956 commented Jun 28, 2024

I am working on it now - unless some other bug shows up - this is the last piece before releasing 5.5 - so hopefully 5.5 will go out before the end of July - and the feature will be in main (so you can develop with it) in the next 2 weeks.

As to your second question - Flask-ALchemy-Lite - which was just released for the first time a month or 2 ago - I think removes many of the concerns that folks had with Flask-Alchemy - which at the time tried to completely wrap Sqlalchemy models, queries, etc - which made it just different enough that it was very confusing. FAL is a very very thin layer - just providing the necessary glue to easily work with Flask - mostly just adding session management for web requests - all models, queries, etc are done using standard SQLAlchemy 2.x methods and conventions.

jwag956 added a commit that referenced this issue Jul 3, 2024
- This introduces new pre-configured models that use 'modern' sqlalchemy type annotations
- The querying is done using the 2.0 select() mechanism (rather than the old query interface)
- Enhance view_scaffold test harness to work with either Flask-SQLAlchemy or Flask-SQLAlchemy-Lite
- FS-Lite requires newer Flask/Werkzeug - bump up lowest tested versions
- per sqlalchemy best practice - don't install mypy extension or stubs

close #989
jwag956 added a commit that referenced this issue Jul 3, 2024
- This introduces new pre-configured models that use 'modern' sqlalchemy type annotations
- The querying is done using the 2.0 select() mechanism (rather than the old query interface)
- Enhance view_scaffold test harness to work with either Flask-SQLAlchemy or Flask-SQLAlchemy-Lite
- FS-Lite requires newer Flask/Werkzeug - bump up lowest tested versions
- per sqlalchemy best practice - don't install mypy extension or stubs

close #989
@jwag956 jwag956 closed this as completed in 25ad68d Jul 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

2 participants