Allowed the oauth login to work with spa #891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SECURITY_REDIRECT_HOST by re-wirting the redirect URL, and stopping validate_redirect_url from erroring when the URL points to the redirect host. Ignore the deprecation of pkg_resources in pytest to ensure it runs Added unit tests for these changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #891 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 34 34
Lines 4465 4466 +1
=======================================
+ Hits 4389 4390 +1
Misses 76 76 ☔ View full report in Codecov by Sentry. |
|
An alternative fix was merged with #895 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed the oauth login to work with spa and SECURITY_REDIRECT_HOST by re-wirting the redirect URL, and stopping validate_redirect_url from erroring when the URL points to the redirect host.
Ignore the deprecation of pkg_resources in pytest to ensure it runs
Added unit tests for these changes
Fixes https://github.com/Flask-Middleware/flask-security/issues/884