Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore handled exception when popping the context #1393

Merged
merged 2 commits into from
Mar 23, 2015
Merged

Ignore handled exception when popping the context #1393

merged 2 commits into from
Mar 23, 2015

Commits on Mar 23, 2015

  1. Switch away from using None as default value for the exception when t… 

    …earing down a context.

When an exception has been handled when using the request / app context in a with statement, `sys.exc_info()` will still contain the exception information even though it has been handled already. The `__exit__` methods pass in `None` for the exception value in that case, which needs to be distinguisable from the default value for the `exc` parameter. Use a dedicated singleton sentinel value instead.
    @mjpieters
    mjpieters committed Mar 23, 2015
    Configuration menu
    Copy the full SHA
    ec0d208 View commit details
    Browse the repository at this point in the history

  2. If this patch gets accepted I may as well be added here.

    @mjpieters
    mjpieters committed Mar 23, 2015
    Configuration menu
    Copy the full SHA
    ecaaa50 View commit details
    Browse the repository at this point in the history