Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warnings for add_etags & mimetype guessing for send_file() #1849

Closed
wants to merge 1 commit into from
Closed

Conversation

dsully
Copy link
Contributor

@dsully dsully commented Jun 2, 2016

No description provided.

@untitaker
Copy link
Contributor

The tests pass even if the deprecation warnings are not removed. That means they were ineffective from the beginning. I'll investigate this.

@untitaker
Copy link
Contributor

@dsully I'll merge #1878 and then this one.

@untitaker untitaker self-assigned this Jun 3, 2016
@untitaker untitaker closed this in 8458cc5 Jun 3, 2016
@untitaker
Copy link
Contributor

Thanks! I applied your changes to master.

@davidism davidism mentioned this pull request Jun 4, 2016
6 tasks
@@ -553,7 +538,9 @@ def send_file(filename_or_fp, mimetype=None, as_attachment=False,
rv.cache_control.max_age = cache_timeout
rv.expires = int(time() + cache_timeout)

if add_etags and filename is not None:
if add_etags and filename is not None and file is None:

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

untitaker added a commit that referenced this pull request Aug 20, 2016
untitaker added a commit that referenced this pull request Aug 20, 2016
@davidism davidism mentioned this pull request Jun 26, 2017
8 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants