-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecation warnings for add_etags & mimetype guessing for send_file() #1849
Conversation
The tests pass even if the deprecation warnings are not removed. That means they were ineffective from the beginning. I'll investigate this. |
Thanks! I applied your changes to master. |
@@ -553,7 +538,9 @@ def send_file(filename_or_fp, mimetype=None, as_attachment=False, | |||
rv.cache_control.max_age = cache_timeout | |||
rv.expires = int(time() + cache_timeout) | |||
|
|||
if add_etags and filename is not None: | |||
if add_etags and filename is not None and file is None: |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
No description provided.