Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ascii #2115

Closed
wants to merge 4 commits into from
Closed

Feature/ascii #2115

wants to merge 4 commits into from

Conversation

jjoliveira
Copy link
Contributor

Implemented the solution purposed by @dsully for issue #1286

Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please rebase to the upstream master. You currently have a weird merge commit in your PR.

@@ -504,6 +504,11 @@ def send_file(filename_or_fp, mimetype=None, as_attachment=False,
a :class:`~datetime.datetime` or timestamp.
If a file was passed, this overrides its mtime.
"""
import warnings

This comment was marked as off-topic.

@@ -504,6 +504,11 @@ def send_file(filename_or_fp, mimetype=None, as_attachment=False,
a :class:`~datetime.datetime` or timestamp.
If a file was passed, this overrides its mtime.
"""
import warnings
if type(filename_or_fp) is str:

This comment was marked as off-topic.

@@ -958,3 +963,16 @@ def total_seconds(td):
:rtype: int
"""
return td.days * 60 * 60 * 24 + td.seconds

def is_ascii(string_to_test):

This comment was marked as off-topic.

:returns: True if string_to_test is fully ASCII encoded, False if not
:rtype: boolean
"""
if all(ord(char) < 128 for char in string_to_test):

This comment was marked as off-topic.

@jjoliveira
Copy link
Contributor Author

@ThiefMaster so is it better to delete this branch and create a new updated one? Or do you have any better suggestion?

@ThiefMaster
Copy link
Member

No, just rebase/amend and then force-push. That will update this PR without adding even more commits.

@jjoliveira
Copy link
Contributor Author

Why did the checks failed?

@ThiefMaster
Copy link
Member

There's a syntax error. Please test code before committing/pushing it...

@jjoliveira
Copy link
Contributor Author

Sorry it was a misunderstood with my colleagues.

@davidism
Copy link
Member

davidism commented Apr 8, 2017

Closing because #2223 added support for UTF-8 filenames.

@davidism davidism closed this Apr 8, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants