Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use string concat in jsonify #2577

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Use string concat in jsonify #2577

merged 1 commit into from
Jan 3, 2018

Conversation

davidism
Copy link
Member

@davidism davidism commented Jan 3, 2018

#1262 added a newline at the end of the response body from jsonfiy. It passed a tuple to the Response, which is more appropriate for streaming responses. Instead, use a simple + '\n' and pass a string. This allows the content length header to be calculated while creating the response object (#1877).

ref pallets/werkzeug#1130

@davidism davidism added this to the 1.0 milestone Jan 3, 2018
@davidism davidism merged commit 2bec58f into master Jan 3, 2018
@davidism davidism deleted the jsonify-str branch January 3, 2018 21:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant