fix #2736 - remove explicit check for list as a return value in make_response #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesseops
changed the title
davidism
approved these changes
Apr 27, 2018
|
Give me a second, I need to change this to be against 1.0-maintenance. |
|
OK, your fork is probably going to be messed up after this, since you made the PR from your master and I just force pushed it to look like 1.0-maintenance. You can probably fix it by fetching and force pushing origin/master and origin/1.0-maintenance to your fork once this is merged, or just delete and fork again. In the future, remember to make PRs from branches to avoid this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue introduced in #2256 which breaks a custom response class that supports returning lists from view functions.
A list is not an expected response value and is not intended to be handled by
make_response. I'm unsure why it made it's way into this instance check, but there are no consequences to removing it, based on what I can see in the tests & related code.