Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add venv and .venv to .gitignore #4087

Merged
merged 1 commit into from
May 21, 2021
Merged

Add venv and .venv to .gitignore #4087

merged 1 commit into from
May 21, 2021

Conversation

greyli
Copy link
Member

@greyli greyli commented May 21, 2021

Although we use python -m venv env in the contributing guide as the example, we don't need to force the contributor to use env.

@ThiefMaster
Copy link
Member

People can use .git/info/exclude to add ignores locally, but I'd like to have .venv on gitignore as well since it's a very common name for virtualenvs, and it saves you one small step after setting up your environment...

@greyli
Copy link
Member Author

greyli commented May 21, 2021

I just learned the local gitignore thing, thanks. I normally use venv as the name of the virtual environment.

@davidism davidism merged commit 6b1c4e9 into pallets:2.0.x May 21, 2021
@greyli greyli deleted the gitignore branch May 21, 2021 23:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants