Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing Markup from flask #5085

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

lucaswerkmeister
Copy link
Contributor

@lucaswerkmeister lucaswerkmeister commented Apr 25, 2023

I am not done with the checklist yet, will follow up immediately. But the fix is also very trivial, so I figured I’d submit it first and let you take a look already?

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code. – N/A, imho
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs. – N/A, imho
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@lucaswerkmeister
Copy link
Contributor Author

Not sure if the checklist entry about adding tests applies? I can’t find any existing tests for deprecation warnings (git grep -i deprec tests/).

@davidism
Copy link
Member

This is fine, thanks for catching and fixing it.

@davidism davidism changed the base branch from main to 2.3.x April 25, 2023 19:51
@davidism davidism added this to the 2.3.1 milestone Apr 25, 2023
@davidism davidism merged commit 0867dce into pallets:2.3.x Apr 25, 2023
@lucaswerkmeister lucaswerkmeister deleted the patch-1 branch April 25, 2023 20:13
@pallets pallets locked and limited conversation to collaborators Apr 25, 2023
@davidism
Copy link
Member

Flask 2.3.1 is now available on PyPI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import Markup from flask
2 participants