Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep relative redirect locations by default #2352

Closed
davidism opened this issue Mar 16, 2022 · 1 comment · Fixed by #2354
Closed

keep relative redirect locations by default #2352

davidism opened this issue Mar 16, 2022 · 1 comment · Fixed by #2354
Assignees
@davidism
Milestone
2.1.0

Comments

@davidism
Copy link
Member

When Response.autocorrect_location_header was added in 2011 0ec643b, it was documented as "correct the location header to be RFC conformant". It was referring to RFC 2616. That was superseded by RFC 7231 in 2014, which allows relative URLs. MDN lists all browsers as compliant with this. Switch autocorrect_location_header to be disabled by default.
@davidism davidism added this to the 2.1.0 milestone Mar 16, 2022
@davidism davidism self-assigned this Mar 16, 2022
@davidism
Copy link
Member Author

I've confirmed that Firefox, Chrome, Edge, urllib.request.urlopen, urllib.request.FancyURLOpener, requests.get, httpx.get, curl -L, wget, and aria2c all follow relative redirect correctly.

@davidism davidism mentioned this issue Mar 17, 2022
Merged
@davidism davidism mentioned this issue Mar 25, 2022
Merged
RobbeSneyders added a commit to spec-first/connexion that referenced this issue Mar 28, 2022
@RobbeSneyders
Update tests for changed werkzeug behavior in 2.1
2dcfe14 
pallets/werkzeug#2352
snarfed added a commit to snarfed/granary that referenced this issue Mar 29, 2022
@snarfed
update tests to handle werkzeug 2.1.0 defaulting Location header to r…
2a3ecc1 
…elative URL

https://werkzeug.palletsprojects.com/en/2.1.x/changes/#version-2-1-0
pallets/werkzeug#2352
#293
RobbeSneyders added a commit to spec-first/connexion that referenced this issue Mar 31, 2022
@RobbeSneyders
Add empty connexion middleware (#1502)
895d3d4 
* Add empty connexion middleware

* Address PR comments

* Bump minimum Flask version to 2

* Update tests for changed werkzeug behavior in 2.1

pallets/werkzeug#2352
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidism davidism

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

modern redirect behavior pallets/werkzeug
1 participant
@davidism