__wrapped__
is always set on unbound local proxy
#2497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctest calls
inspect.unwrap
, which doesgetattr(obj, "__wrapped__")
, which would fail if the proxy was anything but a function. In Flask 2.2, the proxies no longer use functions, so users started reporting that their doctests were failing.Now the proxy always records what it's wrapping, and returns that when accessing
__wrapped__
when unbound. When bound, the attribute access is always passed through to the real object, rather than always returning the proxy's value.fixes #2485