Fix CacheControl issues #2882
Merged
Fix CacheControl issues #2882
+70
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazerM
force-pushed
the
feature/cache-control-issues
branch
from
333ad19
to
8bff7d0
Compare
Cache-Control no-transform directive is a boolean no-transform has no arguments as a request or response directive (RFC 9111). Prior to this fix, cc.no_transform would return None whether the directive is present or not. Cache-Control min-fresh directive requires argument The type for this property is `int | None`, so getting `"*"` for a malformed directive is surprising. I think dropping the empty value here is better than fixing the type. Fix CacheControl getter type stubs - cache_control_property with type=bool never return None - some non-bool types were marked as returning bool instead of str - max_stale can return "*" in addition to int or None Reflect immutability of RequestCacheControl in type stubs Fix CacheControl setter type stubs mypy doesn't use the type of setters as of 1.9.0 (see python/mypy#3004), but I think it's still good to have these be accurate (maybe the other type checkers work better here). mypy's recommendation is to use `# type: ignore` comments if setter types don't match getters, which you see when setting no_cache to True. Support must-understand response directive
davidism
force-pushed
the
feature/cache-control-issues
branch
from
9e043b4
to
b28001e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-transformis a boolean, rather than alwaysNone.min-freshis an int, returningNoneif empty rather than*.None.strnotbool.max-stalecan return"*"must-understandresponse property.Fixes #2881