try-except in inner() in run_simple() leaves exceptions grounds #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoloseem
changed the title
|
"May" is a bit of a weak statement. Ideally it should fully fix the bug. |
|
ID suggest putting the original Code into a function or clearing theexception state on Python 2 |
|
@yoloseem Any update on this? |
|
@untitaker well... so far, no. |
|
Looks like the referenced Flask issue was fixed by pallets/flask#1393. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try-exceptininner()inrun_simple()leaves exceptions grounds. Whenuse_reloaderis set toTrue, at that pointKeyErroris raised and in Flask environment, by mysterious reason the exception grounds shall be given to signal handlers, and it is seen as an exception. (Refer pallets/flask#1694 / this patch may fixes this issue.)