Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce API hits and reduce complexity of iptables/nft client bash scripts #25

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

qwell
Copy link
Contributor

@qwell qwell commented Oct 21, 2020

I was curious why the Go client was recommended over the bash client, so I read the code and fixed some bash stuff.

I now see why the Go client is recommended.

Copy link
Member

@fredposner fredposner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go client also has some checks on iptables, recreating the chain if needed, etc.

Thank you for making this client better. Your submission is greatly appreciated.

@fredposner fredposner self-assigned this Oct 21, 2020
@fredposner fredposner merged commit 848a26b into palner:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants