-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : upgraded the app with evm module to SDK v0.50 #1036
Conversation
Here are few things we have to do after fixing errors in each module
|
Update this branch with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still there are few things need to be updated:
- Add signer field proto annotation, remove
GetSigners
andGetSignBytes
implementations in every sdk.Msg defined in this module. - Add EndBlocker, BeginBlocker and other compiler assertions (if required any) in module.go.
- Update Endblocker method structure to new SDK defined type if there are not validator updates involved in it.
- Update BeginBlocker method structure.
Please go through migration docs much deeper and update any if still not updated.
app/app.go
Outdated
nil, | ||
nil, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these values are nil? Remove these fields if not needed or add TODO comment if they need to be updated later.
Warning Paloma is using a custom signer function using an embedded |
0f12f68
to
4204130
Compare
sdkCtx := sdk.UnwrapSDKContext(ctx) | ||
logger := k.Logger(sdkCtx).WithFields( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please start using liblog.FromSDKLogger(k.Logger(SdkCtx)
in the future. There are still ocurrances here without.
No description provided.