Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt gas estimation to reduce 120% safety buffer #1283

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

byte-bandit
Copy link
Contributor

Related Github tickets

Background

This change addresses the inflated estimate that used to include a 1.2 modifier applied to the limit in as a security margin.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes

@byte-bandit byte-bandit requested a review from maharifu September 5, 2024 12:30
maharifu
maharifu previously approved these changes Sep 5, 2024
Copy link
Contributor

@maharifu maharifu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left a note about a comment that can be deleted as well.

util/libcons/consensus.go Outdated Show resolved Hide resolved
Co-authored-by: Luis Carvalho <mail.lmcarvalho@gmail.com>
@byte-bandit byte-bandit merged commit 346ec13 into palomachain:master Sep 5, 2024
3 checks passed
@byte-bandit byte-bandit deleted the clohr/gas branch September 5, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants