Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow down evm event checking #282

Merged

Conversation

MechanicalTyler
Copy link
Contributor

Related Github tickets

Background

This was previously checking every 5 seconds for events to send a token to Paloma. This may be unnecessarily using up RPC calls for pigeons when not much is happening. Slowing this down, which will effectively reduce the call numbers while batching events that may happen together.

Also removed an unused interval accidentally left in

Testing completed

  • this is a loop interval, no tests exist or are needed for it
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes

This was previously checking every 5 seconds for events to send a token
to Paloma.  This may be unnecessarily using up RPC calls for pigeons
when not much is happening.  Slowing this down, which will effectively
reduce the call numbers while batching events that may happen together.
Copy link
Collaborator

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@taariq
Copy link
Contributor

taariq commented Sep 19, 2023

Hold on now. We are slowing down, but what happens when we launch GRAIN and it's trading on EVM and moving back and forth? Well have to cut a new release just to handle new volume?

@MechanicalTyler
Copy link
Contributor Author

@taariq Yes, that's true. This is basically a slow down so we can rule it out or confirm it as a contributing factor to our current problems relaying.

@taariq taariq merged commit 3fc2b58 into palomachain:master Sep 19, 2023
@taariq taariq deleted the toaster/slow-down-evm-event-watching branch September 19, 2023 15:25
@taariq
Copy link
Contributor

taariq commented Sep 19, 2023

@ToasterTheBrave Thanks. understdood.

@pegahcarter
Copy link

I'm interested to know how the value of 1 minute was decided. Is this an arbitrary constant?

@taariq
Copy link
Contributor

taariq commented Sep 28, 2023

@pegahcarter it's a best guess. the volume of rpc queries on the validator endpoints were hitting millions per month with every five seconds. this change will need to be eventually dynamic and based on the bridge volume for each particular chain level of bridge activity. lots of optimizations to explore. 1 minute was immediate relief without losing the bridge security model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants