Extract quota exceeded testing to use an array #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves readability while making it simpler to maintain and extend
|
Hmmm. Maybe this is me being overly curmudgeonly, but I believe that Array.indexOf is a more recent addition to browsers than localStorage, so introducing it could potentially reduce the usability of lscache across browsers. I'm hesitant to make a change that could reduce the browser compatibility, if it doesn't have a big benefit. Anyone else have thoughts? |
|
About browsers support localStorage and Array.indexOf. According to StatCounter:
According to NetMarketShare:
In my opinion, this optimization does not add readability and performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves readability while making it simpler to maintain and extend