Added Authorization Bearer token support as per RFC6750 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mbag
commented
Aug 7, 2018
mbag
commented
- appended Authorization header token parsing after X-Consul-Token
- added test cases
- updated website documentation to mention Authorization header
* appended Authorization header token parsing after X-Consul-Token * added test cases * updated website documentation to mention Authorization header
|
@splashx please review changes made to the Consul. If you are OK with them, create PR to consul master repo. I can continue discussion with consul maintainers on hashicorp#4483 |
* improve tests * improve Bearer parsing
splashx
approved these changes
Aug 8, 2018
agent/http_test.go
Outdated
| @@ -736,6 +736,19 @@ func TestACLResolution(t *testing.T) { | |||
| reqBothTokens, _ := http.NewRequest("GET", "/v1/catalog/nodes?token=baz", nil) | |||
| reqBothTokens.Header.Add("X-Consul-Token", "zap") | |||
|
|
|||
| // Request with Authorization token | |||
There was a problem hiding this comment.
Add on: Authorization *Bearer* token
agent/http_test.go
Outdated
| reqAuthAndXToken, _ := http.NewRequest("GET", "/v1/catalog/nodes", nil) | ||
| reqAuthAndXToken.Header.Add("X-Consul-Token", "xtoken") | ||
| reqAuthAndXToken.Header.Add("Authorization", "Bearer notparsed") | ||
|
|
||
| a := NewTestAgent(t.Name(), "") |
There was a problem hiding this comment.
Add a test for when Authorization: Bearer is passed (we expect the test to fail because of this line )
|
LGTM please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.