Skip to content

Commit

Permalink
[MINOR][SQL][TESTS] Changes the test:runMain in the code comments t…
Browse files Browse the repository at this point in the history
…o `Test/runMain`

### What changes were proposed in this pull request?
This PR only changes the `test:runMain` description related to run command in the code comments to `Test/runMain`.

### Why are the changes needed?
When we use the execution command in the code comments, we will see the following compilation warning:

```
build/sbt "sql/test:runMain org.apache.spark.sql.execution.benchmark.TopKBenchmark"
```

```
[warn] sbt 0.13 shell syntax is deprecated; use slash syntax instead: sql / Test / runMain
```

The relevant comments should be updated to eliminate the compilation warnings when run the command.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Manually run the test using the updated command and check that the corresponding compilation warning is no longer present.

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#47767 from LuciferYang/runMain-command-comments.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: yangjie01 <yangjie01@baidu.com>
  • Loading branch information
LuciferYang committed Aug 15, 2024
1 parent 00b8cb3 commit 7b43a6f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ class GenTPCDSDataConfig(args: Array[String]) {
private def printUsageAndExit(exitCode: Int): Unit = {
// scalastyle:off
System.err.println("""
|build/sbt "test:runMain <this class> [Options]"
|build/sbt "Test/runMain <this class> [Options]"
|Options:
| --master the Spark master to use, default to local[*]
| --dsdgenDir location of dsdgen
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ import org.apache.spark.util.collection.unsafe.sort.UnsafeExternalSorter
* 1. without sbt:
* bin/spark-submit --class <this class> --jars <spark core test jar> <spark sql test jar>
* 2. build/sbt build/sbt ";project sql;set javaOptions
* in Test += \"-Dspark.memory.debugFill=false\";test:runMain <this class>"
* in Test += \"-Dspark.memory.debugFill=false\";Test/runMain <this class>"
* 3. generate result: SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt ";project sql;set javaOptions
* in Test += \"-Dspark.memory.debugFill=false\";test:runMain <this class>"
* in Test += \"-Dspark.memory.debugFill=false\";Test/runMain <this class>"
* Results will be written to
* "benchmarks/ExternalAppendOnlyUnsafeRowArrayBenchmark-results.txt".
* }}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ import org.apache.spark.sql.internal.SQLConf
* 1. without sbt:
* bin/spark-submit --class <this class>
* --jars <spark core test jar>,<spark catalyst test jar> <sql core test jar>
* 2. build/sbt "sql/test:runMain <this class>"
* 2. build/sbt "sql/Test/runMain <this class>"
* 3. generate result:
* SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain <this class>"
* SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/Test/runMain <this class>"
* Results will be written to "benchmarks/TakeOrderedAndProjectBenchmark-results.txt".
* }}}
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ import org.apache.spark.sql.internal.SQLConf.WINDOW_GROUP_LIMIT_THRESHOLD
* {{{
* 1. without sbt: bin/spark-submit --class <this class>
* --jars <spark core test jar>,<spark catalyst test jar> <spark sql test jar>
* 2. build/sbt "sql/test:runMain <this class>"
* 3. generate result: SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain <this class>"
* 2. build/sbt "sql/Test/runMain <this class>"
* 3. generate result: SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/Test/runMain <this class>"
* Results will be written to "benchmarks/TopKBenchmark-results.txt".
* }}}
*/
Expand Down

0 comments on commit 7b43a6f

Please sign in to comment.