Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (Menu) Footer is not visible completely when navigation bar is visible in mobile browsers #138

Merged
merged 1 commit into from
Jun 8, 2021
Merged

fix: (Menu) Footer is not visible completely when navigation bar is visible in mobile browsers #138

merged 1 commit into from
Jun 8, 2021

Conversation

memoyil
Copy link
Contributor

@memoyil memoyil commented Jun 4, 2021

It is also so hard to change language in safari when clicking the language button mostly activates navigation bar, and in android it is not visible at first glance unless you scroll it

Before:

WhatsApp.Video.2021-06-04.at.13.13.10.mp4

After:

WhatsApp.Video.2021-06-04.at.13.15.03.mp4

==================

It also fixes language selection menu top part is not visible in small screens (it is under the header bar) when in wallet browsers or safari with navigation bar at the bottom.

Before:

WhatsApp.Video.2021-06-04.at.13.30.15.mp4

After:

WhatsApp.Video.2021-06-04.at.13.29.49.mp4

@memoyil memoyil changed the title fix: (Menu) Footer is not visible completely when navigation bar is visible in safari fix: (Menu) Footer is not visible completely when navigation bar is visible in mobile browsers Jun 6, 2021
@hachiojidev hachiojidev merged commit fa6fc66 into pancakeswap:master Jun 8, 2021
@memoyil memoyil deleted the feature/fix_footer_fix_to_bottom_safari branch June 9, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants