Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (Menu) Footer is not visible completely when navigation bar is visible in mobile browsers #138

Merged
merged 1 commit into from
Jun 8, 2021
Merged

fix: (Menu) Footer is not visible completely when navigation bar is visible in mobile browsers #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/pancake-uikit/src/__tests__/components/dropdown.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ it("renders correctly", () => {
background-color: #FFFFFF;
box-shadow: 0px 2px 12px -8px rgba(25,19,38,0.1),0px 1px 1px rgba(25,19,38,0.05);
padding: 16px;
max-height: 500px;
max-height: 400px;
overflow-y: auto;
z-index: 10;
border-radius: 4px;
Expand Down
2 changes: 1 addition & 1 deletion packages/pancake-uikit/src/__tests__/widgets/menu.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ it("renders correctly", () => {
flex-shrink: 0;
background-color: #FFFFFF;
width: 0;
height: 100vh;
height: 100%;
-webkit-transition: padding-top 0.2s,width 0.2s cubic-bezier(0.4,0,0.2,1);
transition: padding-top 0.2s,width 0.2s cubic-bezier(0.4,0,0.2,1);
border-right: 0;
Expand Down
2 changes: 1 addition & 1 deletion packages/pancake-uikit/src/components/Dropdown/Dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const DropdownContent = styled.div<{ position: Position }>`
background-color: ${({ theme }) => theme.nav.background};
box-shadow: ${({ theme }) => theme.shadows.level1};
padding: 16px;
max-height: 500px;
max-height: 400px;
overflow-y: auto;
z-index: ${({ theme }) => theme.zIndices.dropdown};
border-radius: ${({ theme }) => theme.radii.small};
Expand Down
2 changes: 1 addition & 1 deletion packages/pancake-uikit/src/widgets/Menu/components/Panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const StyledPanel = styled.div<{ isPushed: boolean; showMenu: boolean }>`
flex-shrink: 0;
background-color: ${({ theme }) => theme.nav.background};
width: ${({ isPushed }) => (isPushed ? `${SIDEBAR_WIDTH_FULL}px` : 0)};
height: 100vh;
height: 100%;
transition: padding-top 0.2s, width 0.2s cubic-bezier(0.4, 0, 0.2, 1);
border-right: ${({ isPushed }) => (isPushed ? "2px solid rgba(133, 133, 133, 0.1)" : 0)};
z-index: 11;
Expand Down