feat: Implement dropdown component with search #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hachiojidev
suggested changes
Mar 17, 2021
| import { DropdownSearchOptionProps, DropdownSearchProps } from "./types"; | ||
|
|
||
| const StyledInput = styled(Input)` | ||
| border-radius: 16px; |
There was a problem hiding this comment.
Input already has a border radius of 16px
| }; | ||
|
|
||
| useEffect(() => { | ||
| if (dropdownRef.current) { |
There was a problem hiding this comment.
Please put dropdownRef in the dependency list
|
|
||
| export interface DropdownSearchOptionProps { | ||
| label: string; | ||
| value: any; |
There was a problem hiding this comment.
Number or string? If so ReactText.
|
@hachiojidev you can review it again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Chef-Chungus I implemented as we spoke with minor differences, instead of selecting the item when searching, I filtered out the other items which as a user perspective makes more sense. I would like to hear your opinion as well.