Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Put shadow under the bunny head of slider component #25

Merged
merged 2 commits into from
Mar 29, 2021
Merged

fix: Put shadow under the bunny head of slider component #25

merged 2 commits into from
Mar 29, 2021

Conversation

memoyil
Copy link
Contributor

@memoyil memoyil commented Mar 22, 2021

No description provided.

@memoyil
Copy link
Contributor Author

memoyil commented Mar 22, 2021

@Chef-Chungus Ready to merge

hachiojidev
hachiojidev reviewed Mar 23, 2021
View reviewed changes
Copy link
Contributor

@hachiojidev hachiojidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please send us a screenshot of the changes.

@memoyil
Copy link
Contributor Author

memoyil commented Mar 23, 2021

@hachiojidev

image

image

image

image

@Chef-Chungus
Copy link
Contributor

Chef-Chungus commented Mar 23, 2021 •
edited
Loading

@memoyil looks like the bunny head/shadow is getting cropped on the sides
image

@RabbitDoge
Copy link
Contributor

Does this come from the figma ?

@memoyil
Copy link
Contributor Author

memoyil commented Mar 23, 2021

@Chef-Chungus @hachiojidev Should be ok now

image

image

image

image

@memoyil memoyil requested a review from hachiojidev March 23, 2021 15:35
@Chef-Chungus
Copy link
Contributor

@RabbitDoge @hachiojidev looks good for me

@RabbitDoge RabbitDoge merged commit 92da5b5 into pancakeswap:master Mar 29, 2021
@memoyil memoyil deleted the fix/slider_put_shadow_on_bunny_head branch April 9, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RabbitDoge RabbitDoge RabbitDoge approved these changes

@hachiojidev hachiojidev Awaiting requested review from hachiojidev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@memoyil @Chef-Chungus @RabbitDoge @hachiojidev