Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Stepper #42

Merged
merged 1 commit into from
Mar 31, 2021
Merged

feat: Stepper #42

merged 1 commit into from
Mar 31, 2021

Conversation

RabbitDoge
Copy link
Contributor

[ ] Before opening a pull request, please read the contributing guidelines first
[ ] If your PR is work in progress, open it as draft
[ ] Before requesting a review, all the checks need to pass
[ ] Explain what your PR does

@RabbitDoge RabbitDoge requested a review from hachiojidev as a code owner March 31, 2021 06:26
hachiojidev
hachiojidev approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@hachiojidev hachiojidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot less code than I anticipated for this component, nice work.

@RabbitDoge RabbitDoge merged commit 8b1b72e into master Mar 31, 2021
@RabbitDoge RabbitDoge deleted the stepper branch March 31, 2021 06:45
@RabbitDoge
Copy link
Contributor Author

A lot less code than I anticipated for this component, nice work.

Surprisingly, A small hack helped to keep it cleaner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hachiojidev hachiojidev hachiojidev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RabbitDoge @hachiojidev