[POC] vault manages funds for custom curve hook #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chefburger
commented
Nov 5, 2024
|
|
||
| key.currency0.settle(vault, address(this), 1, false); | ||
| key.currency1.settle(vault, address(this), 1, false); | ||
| } else if (keccak256(action) == keccak256("deposit")) { |
There was a problem hiding this comment.
can regard this as vault.mint with reserveOfApp being updated
chefburger
commented
Nov 5, 2024
| if (amount1 > 0) { | ||
| key.currency1.settle(vault, address(this), amount1, false); | ||
| } | ||
| } else if (keccak256(action) == keccak256("withdraw")) { |
There was a problem hiding this comment.
can regard this as vault.burn with reserveOfApp being updated
chefburger
commented
Nov 5, 2024
| ICLPoolManager.ModifyLiquidityParams calldata params, | ||
| bytes calldata hookData | ||
| ) external override returns (bytes4) { | ||
| revert("banned adding liquidity by non-hook"); |
There was a problem hiding this comment.
This should be banned anyway even not taking this approach because custom curve will have its own liquidity logic
chefburger
commented
Nov 5, 2024
| uint256 amount1, | ||
| bytes calldata hookData | ||
| ) external override returns (bytes4) { | ||
| revert("banned donating by non-hook"); |
There was a problem hiding this comment.
in fact, it's fine to allow ppl to donate because it will all goes to hook's liquidity position
chefburger
commented
Nov 5, 2024
| if (params.zeroForOne) { | ||
| // input token is token0, amt = amountSpecified, deposit it to vault | ||
| key.currency0.take(vault, address(this), (-params.amountSpecified).toUint256(), false); | ||
| _dispatch(abi.encode("deposit", abi.encode(key, (-params.amountSpecified).toUint256(), 0))); |
There was a problem hiding this comment.
Those two could be further combined i.e take() and settle() are exactly opposite direction hence could cancel out which means we could call donate without any settlement here :
- less gas
- reserveOfApp is updating but we don't need to have the token in the pool ahead of time
chefburger
commented
Nov 5, 2024
|
|
||
| // output token is token1, amt = amountUnSpecified, withdraw it from vault | ||
| _dispatch(abi.encode("withdraw", abi.encode(key, 0, amountUnSpecified, address(this)))); | ||
| key.currency1.settle(vault, address(this), amountUnSpecified.toUint256(), false); |
There was a problem hiding this comment.
Same logic, those two could be combined to simplify the flow
chefburger
changed the title
|
Make it WIP since we won't take it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This POC expects to work as a reference in case third party integration and would like to manage funds and reflect it on reserveOfApps