<poc> Example of option 1 #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ChefMist
commented
Nov 12, 2024
src/pool-bin/libraries/BinPool.sol
Outdated
| /// <WIP> to discuss if we want to enforce this -- otherwise user can potentially add below 1e9 liquidity | ||
| /// but can't withdraw if there's no other lp to help push the min share up | ||
| uint256 balanceShare = self.shareOfBin[binId]; | ||
| if (balanceShare > 0 && balanceShare < MINIMUM_SHARE) { |
There was a problem hiding this comment.
[wip] if this option is taken, to discuss if we want this check.
ChefSnoopy
reviewed
Nov 12, 2024
| uint256 balanceShare = self.shareOfBin[binId]; | ||
| if (balanceShare > 0 && balanceShare < MINIMUM_SHARE) { | ||
| revert BinPool__BelowMinimumShare(balanceShare); | ||
| } |
There was a problem hiding this comment.
only concern is that user maybe will always get revert when try to withdraw all , if left shares of bin is below MINIMUM_SHARE.
There was a problem hiding this comment.
nice, this would be a con of this approach
So example would be:
- alice added min_share + 1 liquidity = 1e9 + 1 (pool has 1e9 + 1 share)
- bob added 10 liquidity (pool has 1e9 + 1 + 10 share)
- alice remove 11 liquidity (pool left with 1e9 share)
- bob is stuck and cannot remove his share
There was a problem hiding this comment.
per discussion with Snoopy, might worth to consider to limit from the perspective of user position instead of the whole bin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.