POC/ hexen r7 option 1 optimization #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chefburger
reviewed
Nov 12, 2024
|
chefburger
reviewed
Nov 12, 2024
| uint256 userPositionShare = self.positions.get(owner, binId, salt).share; | ||
| if (userPositionShare > 0 && userPositionShare < MINIMUM_SHARE) { | ||
| revert UserPosition__BelowMinimumShare(userPositionShare); | ||
| } |
There was a problem hiding this comment.
It might be better to add this part in BinPosition::addShare, BinPosition::subShare:
- Conceptually, the check belongs to user position
- save some gas since it avoids call position.get twice
There was a problem hiding this comment.
ok , this is just a POC. will refactor logic if decide to use this.
…m threshold Remove all shares if the remaining shares fall below the minimum threshold
|
|
||
| /// @dev Ensure bin user's position share is either 0 or greater than minimum share | ||
| uint256 userPositionShare = self.positions.get(owner, binId, salt).share; | ||
| if (userPositionShare > 0 && userPositionShare < MINIMUM_SHARE) { |
There was a problem hiding this comment.
Suggested change
| if (userPositionShare > 0 && userPositionShare < MINIMUM_SHARE) { | |
| if (userPositionShare < MINIMUM_SHARE) { |
I think this will be sufficient
There was a problem hiding this comment.
no , if removed all , userPositionShare will be 0 now , will get revert error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check user position share compared with min