feat: Add new pool initialization action and validation at PM call #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefMist
changed the title
|
CI fail as expected due to exceed bytecode size. see #27 on the passing PR |
chefburger
reviewed
Nov 15, 2024
chefburger
reviewed
Nov 15, 2024
chefburger
reviewed
Nov 15, 2024
chefburger
reviewed
Nov 15, 2024
src/modules/V3ToV4Migrator.sol
Outdated
| error InvalidAction(bytes4 action); | ||
| error OnlyMintAllowed(); | ||
| error OnlyAddLiqudityAllowed(); | ||
| error BlacklistedAction(); |
There was a problem hiding this comment.
This is duplicate with OnlyMintAllowed/OnlyAddLiqudityAllowed?
… feat/add-action-protect-pm-v2
[Part 2 of 2] feat: Add new pool initialization action and validation at PM call
ChefMist
changed the title
jpopxfile
reviewed
Nov 18, 2024
| uint256 numActions = actions.length; | ||
|
|
||
| for (uint256 actionIndex = 0; actionIndex < numActions; actionIndex++) { | ||
| uint256 action = uint8(actions[actionIndex]); |
There was a problem hiding this comment.
Why casting uint8 here for a uint256 variable?
There was a problem hiding this comment.
actions[actionIndex] returns a bytes1 and we need to explictly convert it to a uint type
|
Update comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: