Add userdata context variable API to PPP callbacks #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth noting for anyone who reviews: only these first 3 files are particularly relevant. Most of the rest of the 15k line diff is just migrating the breaking change
|
AndrewFasano
requested changes
Oct 22, 2021
|
Pretty sure the CI failure is just a one-off-bug in the CI, not an issue with this PR. Merging 🙈 |
AndrewFasano
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1105 for additional context as to the rationale. As for the implementation--PPP callbacks were trickier and required a minor breaking change. The typedefs for PPP callbacks must now be generated using the
PPP_CB_TYPEDEFmacro. Unlike the base callback implementation, this implementation doesn't use trampoline generation and simply hold a separate callback list for those with context variables.