Skip to content

Commit

Permalink
GH1051 Drop astype tests for Mac arm for float128 and complex256 (#1057)
Browse files Browse the repository at this point in the history
* GH1051 Drop astype tests for Mac arm for float128 and complex256

* Fix

* Fix

* Test fix

* Move to macos-latest

* Update test.yml

* GH1051 Lock in tables version to 3.10.1

* GH1049 Deprecate Index and Grouper methods for 2.0 migration (#1050)

* GH1049 Deprecate Index and Grouper methods for migration to 2.0

* GH1049 Deprecate use_nullable_dtypes in read_parquet

* Change signature of StringMethods.rsplit to match pandas (#1056)

* GH1053 @ for DataFrame, eval in place for DataFrame, test migrations (#1054)

* GH1053 @ for DataFrame, eval in place for DataFrame, test migrations

* Formatting and spelling

* GH1053 PR Feedback

* GH1053 Formatting

* GH1043 Update _typing.pyi: add "cross" option to JoinHow (#1044)

* Update _typing.pyi: add "cross" option to JoinHow

* Removed "cross" option from JoinHow and added it back to MergeHow

* Replaced JoinHow with MergeHow in frame.join

* Added a test for join "how"

* Update test_frame.py: used check(assert_type pattern in unit test

* Update test_frame.py

Fix formatting

* Version 2.2.3.241126

---------

Co-authored-by: kroche98 <kroche.md@gmail.com>
Co-authored-by: brzegorzTesco <Grzegorz.Bogdal@Tesco.com>
Co-authored-by: Irv Lustig <irv@princeton.com>
  • Loading branch information
4 people authored Nov 27, 2024
1 parent 7f06ab1 commit b6ae6e8
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ jobs:
strategy:
fail-fast: false
matrix:
# Don't use macos-latest because it is arm64
os: [ubuntu-latest, windows-latest, macos-13]
# macos-latest is arm
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ["3.10", "3.11", "3.12"]

name: OS ${{ matrix.os }} - Python ${{ matrix.python-version }}
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ black = ">=23.3.0"
isort = ">=5.12.0"
openpyxl = ">=3.0.10"
# for tables, MacOS gives random CI failures on 3.9.2
tables = { version = "==3.9.2", python = "<4" } # 3.8.0 depends on blosc2 which caps python to <4
tables = { version = "==3.10.1", python = "<4" } # 3.8.0 depends on blosc2 which caps python to <4
lxml = ">=4.9.1"
pyreadstat = ">=1.2.0"
xlrd = ">=2.0.1"
Expand Down
18 changes: 18 additions & 0 deletions tests/test_series.py
Original file line number Diff line number Diff line change
Expand Up @@ -2429,6 +2429,15 @@ def test_astype_float(cast_arg: FloatDtypeArg, target_type: type) -> None:
s.astype(cast_arg)
pytest.skip("Windows does not support float128")

if (
platform.system() == "Darwin"
and platform.processor() == "arm"
and cast_arg in ("f16", "float128")
):
with pytest.raises(TypeError):
s.astype(cast_arg)
pytest.skip("MacOS arm does not support float128")

check(s.astype(cast_arg), pd.Series, target_type)

if TYPE_CHECKING:
Expand Down Expand Up @@ -2482,6 +2491,15 @@ def test_astype_complex(cast_arg: ComplexDtypeArg, target_type: type) -> None:
s.astype(cast_arg)
pytest.skip("Windows does not support complex256")

if (
platform.system() == "Darwin"
and platform.processor() == "arm"
and cast_arg in ("c32", "complex256")
):
with pytest.raises(TypeError):
s.astype(cast_arg)
pytest.skip("MacOS arm does not support complex256")

check(s.astype(cast_arg), pd.Series, target_type)

if TYPE_CHECKING:
Expand Down

0 comments on commit b6ae6e8

Please sign in to comment.