fix signature of frame.filter

items can be ListLike
pandas-dev · Aug 1, 2024 · fe2af1d · fe2af1d
1 parent 458ecb4
commit fe2af1d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pandas-stubs/core/frame.pyi b/pandas-stubs/core/frame.pyi
@@ -1711,7 +1711,7 @@ class DataFrame(NDFrame, OpsMixin):
     ) -> DataFrame: ...
     def filter(
         self,
-        items: list | None = ...,
+        items: ListLike | None = ...,
         like: _str | None = ...,
         regex: _str | None = ...,
         axis: Axis | None = ...,

diff --git a/tests/test_frame.py b/tests/test_frame.py
@@ -319,6 +319,8 @@ def test_types_filter() -> None:
     df.filter(items=["col1"])
     df.filter(regex="co.*")
     df.filter(like="1")
+    # [PR 964] Docs state `items` is `list-like`
+    df.filter(items=("col2", "col2", 1, tuple([4])))
 
 
 def test_types_setting() -> None: