CI: mypy 0.990 #419
Merged
CI: mypy 0.990 #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Nov 8, 2022
| @@ -1276,8 +1276,6 @@ class DataFrame(NDFrame, OpsMixin): | |||
| @property | |||
| def at(self): ... # Not sure what to do with this yet; look at source | |||
| @property | |||
| def bool(self) -> _bool: ... | |||
There was a problem hiding this comment.
declared as final in the implementation
Dr-Irv
requested changes
Nov 8, 2022
| @@ -822,7 +822,7 @@ def test_sqlalchemy_selectable() -> None: | |||
| class Base(metaclass=sqlalchemy.orm.decl_api.DeclarativeMeta): | |||
| __abstract__ = True | |||
|
|
|||
| class Temp(Base): | |||
| class Temp(Base): # type: ignore[misc] | |||
There was a problem hiding this comment.
can you add a comment here as to why the # type: ignore is needed?
There was a problem hiding this comment.
I honestly don't understand why - I added the error reported by mypy
|
Are most of these due to inheritance? |
Yes, mypy seems now to be stricter about enforcing that a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #336
xref #400