Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-624 Added encoding='infer' to read_sas #644

Closed
wants to merge 2 commits into from
Closed

GH-624 Added encoding='infer' to read_sas #644

wants to merge 2 commits into from

Conversation

ramvikrams
Copy link
Contributor

@ramvikrams ramvikrams commented Apr 13, 2023

  • Tests added: Please use assert_type() to assert the type of any return value

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Apr 13, 2023

I'm going to close this PR. Looking at the pandas as source, we accept any str for encoding that is a valid Python encoding, plus the string infer, and there is not a list of valid python encodings. So this change to pandas 2.0 is not something we need to handle in the stubs.

I've updated #624 to reflect that we don't need to do this.

Thanks for trying!

@ramvikrams
Copy link
Contributor Author

I'm going to close this PR. Looking at the pandas as source, we accept any str for encoding that is a valid Python encoding, plus the string infer, and there is not a list of valid python encodings. So this change to pandas 2.0 is not something we need to handle in the stubs.

I've updated #624 to reflect that we don't need to do this.

Thanks for trying!

thanks

@ramvikrams ramvikrams closed this Apr 13, 2023
@ramvikrams ramvikrams deleted the t160 branch April 21, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants