Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH:624- added date_format to read_table,read_fwf and read_excel #695

Merged
merged 10 commits into from
May 18, 2023
Merged

GH:624- added date_format to read_table,read_fwf and read_excel #695

merged 10 commits into from
May 18, 2023

Conversation

ramvikrams
Copy link
Contributor

@ramvikrams ramvikrams commented May 13, 2023 •
edited
Loading

@ramvikrams ramvikrams changed the title T03 GH:624- added date_format to read_table,read_fwf and read_excel May 13, 2023
@ramvikrams ramvikrams changed the title GH:624- added date_format to read_table,read_fwf and read_excel GH:624- added date_format to read_table,read_fwf and read_excel May 13, 2023
Dr-Irv
Dr-Irv requested changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's remove date_parser as part of this PR since it is deprecated.
  • The date_format argument type needs to be consistent.
  • The tests need to test the new argument.

pandas-stubs/io/excel/_base.pyi Outdated Show resolved Hide resolved
pandas-stubs/io/parsers/readers.pyi Outdated Show resolved Hide resolved
pandas-stubs/io/parsers/readers.pyi Outdated Show resolved Hide resolved
tests/test_io.py Show resolved Hide resolved
@ramvikrams
Copy link
Contributor Author

We actually dont have parse_dates keyword in read_fwf so should it be added

Dr-Irv
Dr-Irv requested changes May 18, 2023
View reviewed changes
pandas-stubs/io/parsers/readers.pyi Outdated Show resolved Hide resolved
pandas-stubs/io/parsers/readers.pyi Outdated Show resolved Hide resolved
tests/test_io.py Outdated Show resolved Hide resolved
tests/test_io.py Outdated Show resolved Hide resolved
Dr-Irv
Dr-Irv approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ramvikrams

@Dr-Irv Dr-Irv merged commit 660c4b0 into pandas-dev:main May 18, 2023
@Dr-Irv Dr-Irv mentioned this pull request May 18, 2023
Open
@ramvikrams ramvikrams deleted the t03 branch May 18, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 2.0 Compatibility Tracker
2 participants
@ramvikrams @Dr-Irv