Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly and support 2.1.1 #781

Merged
merged 4 commits into from
Sep 23, 2023
Merged

Fix nightly and support 2.1.1 #781

merged 4 commits into from
Sep 23, 2023

Conversation

Dr-Irv
Copy link
Collaborator

@Dr-Irv Dr-Irv commented Sep 23, 2023

  • Updated some PYI files to disallow future deprecated features.
  • Updated tests to work with 2.1 and with nightly

@Dr-Irv Dr-Irv requested a review from twoertwein September 23, 2023 06:09
twoertwein
twoertwein reviewed Sep 23, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
twoertwein
twoertwein reviewed Sep 23, 2023
View reviewed changes
pyproject.toml
pyarrow = ">=10.0.1"
pytest = ">=7.1.2"
pyright = ">= 1.1.327"
# pyright 1.1.327 has bug fixed in 1.1.328
pyright = "1.1.326"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which bug is affecting pandas-stubs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear, but 1.1.328 is installed in VS Code pre-release and within VS Code, I get no complaints, but when I install 1.1.327, it doesn't like the use of this pattern in core/generic.pyi:

def somefunc(self: NDFrameT, someargs) -> NDFrameT: ...

complaining like this:

core\generic.pyi:60:15 - error: Type of parameter "self" must be a supertype of its class "NDFrame" (reportGeneralTypeIssues)

1.1.328 is in VSCode, but not on pypi yet

Copy link
Member

@twoertwein twoertwein Sep 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would Self fix the issue?

edit: could also be done later

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If 1.1.328 also fails once released, then I will try that

twoertwein
twoertwein reviewed Sep 23, 2023
View reviewed changes
tests/test_frame.py Outdated Show resolved Hide resolved
@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Sep 23, 2023

@twoertwein addressed all your comments in 3274b29

@twoertwein twoertwein merged commit a912c8e into pandas-dev:main Sep 23, 2023
10 checks passed
@twoertwein
Copy link
Member

Thank you @Dr-Irv !

@Dr-Irv Dr-Irv deleted the fix_nightly_21 branch December 2, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dr-Irv @twoertwein