Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test on 3.12 #839

Merged
merged 4 commits into from
Dec 26, 2023
Merged

CI: test on 3.12 #839

merged 4 commits into from
Dec 26, 2023

Conversation

twoertwein
Copy link
Member

poe pytest (circular import error) fails for me but pytest tests works?! Let's see what happens on the CI.

@twoertwein twoertwein marked this pull request as ready for review December 23, 2023 03:53
@twoertwein
Copy link
Member Author

Unrelated: could replace isort and black with ruff (pandas might replace black with ruff pandas-dev/pandas#56554)

tests/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I look into the Actions on github, it shows that the CI is failing.

But I also don't understand why the jobs aren't showing up in the Conversation tab.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion to help with maintenance. Convert out of draft if you're happy with it.

Comment on lines 1825 to 1830
with pytest_warns_bounded(
DeprecationWarning,
match="datetime.datetime.utcnow",
lower="3.11.99",
version_str=platform.python_version(),
):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this pattern is appearing all over the place, and hopefully we can one day remove it, it might be better to just create a special item in tests/__init__.py that returns

 pytest_warns_bounded(
        DeprecationWarning,
        match="datetime.datetime.utcnow",
        lower="3.11.99",
        version_str=platform.python_version(),
    )

Then we know there is one place that is catching the same warning.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a nicer solution :) pytest_warns_bounded is used in only one place now, so I don't think creating a new function for it would make sense anymore.

@twoertwein twoertwein marked this pull request as ready for review December 24, 2023 01:57
@twoertwein twoertwein requested a review from Dr-Irv December 24, 2023 02:01
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @twoertwein . I like the idea of using pyproject.toml and [tool.pytest.ini_options] to handle the dateutil issue.

@Dr-Irv Dr-Irv merged commit 0a567b4 into pandas-dev:main Dec 26, 2023
13 checks passed
@twoertwein twoertwein deleted the py312 branch February 10, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants