-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: test on 3.12 #839
CI: test on 3.12 #839
Conversation
Unrelated: could replace isort and black with ruff (pandas might replace black with ruff pandas-dev/pandas#56554) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I look into the Actions on github, it shows that the CI is failing.
But I also don't understand why the jobs aren't showing up in the Conversation tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion to help with maintenance. Convert out of draft if you're happy with it.
tests/test_frame.py
Outdated
with pytest_warns_bounded( | ||
DeprecationWarning, | ||
match="datetime.datetime.utcnow", | ||
lower="3.11.99", | ||
version_str=platform.python_version(), | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this pattern is appearing all over the place, and hopefully we can one day remove it, it might be better to just create a special item in tests/__init__.py
that returns
pytest_warns_bounded(
DeprecationWarning,
match="datetime.datetime.utcnow",
lower="3.11.99",
version_str=platform.python_version(),
)
Then we know there is one place that is catching the same warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a nicer solution :) pytest_warns_bounded
is used in only one place now, so I don't think creating a new function for it would make sense anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @twoertwein . I like the idea of using pyproject.toml
and [tool.pytest.ini_options]
to handle the dateutil
issue.
assert_type()
to assert the type of any return valuepoe pytest
(circular import error) fails for me butpytest tests
works?! Let's see what happens on the CI.