Skip to content

Commit

Permalink
DEPR: deprecated nonkeyword arguments in to_html (#54612)
Browse files Browse the repository at this point in the history
deprecated nonkeyword arguments
  • Loading branch information
rsm-23 authored Aug 21, 2023
1 parent 8af96fc commit 04f03fb
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 0 deletions.
1 change: 1 addition & 0 deletions doc/source/whatsnew/v2.2.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ Other API changes
Deprecations
~~~~~~~~~~~~
- Deprecated allowing non-keyword arguments in :meth:`DataFrame.to_hdf` except ``path_or_buf``. (:issue:`54229`)
- Deprecated allowing non-keyword arguments in :meth:`DataFrame.to_html` except ``buf``. (:issue:`54229`)
- Deprecated allowing non-keyword arguments in :meth:`DataFrame.to_json` except ``path_or_buf``. (:issue:`54229`)
- Deprecated allowing non-keyword arguments in :meth:`DataFrame.to_latex` except ``buf``. (:issue:`54229`)
- Deprecated allowing non-keyword arguments in :meth:`DataFrame.to_markdown` except ``buf``. (:issue:`54229`)
Expand Down
3 changes: 3 additions & 0 deletions pandas/core/frame.py
Original file line number Diff line number Diff line change
Expand Up @@ -3134,6 +3134,9 @@ def to_html(
) -> str:
...

@deprecate_nonkeyword_arguments(
version="3.0", allowed_args=["self", "buf"], name="to_html"
)
@Substitution(
header_type="bool",
header="Whether to print column labels, default True",
Expand Down
11 changes: 11 additions & 0 deletions pandas/tests/io/formats/test_to_html.py
Original file line number Diff line number Diff line change
Expand Up @@ -978,3 +978,14 @@ def test_to_html_empty_complex_array():
"</table>"
)
assert result == expected


def test_to_html_pos_args_deprecation():
# GH-54229
df = DataFrame({"a": [1, 2, 3]})
msg = (
r"Starting with pandas version 3.0 all arguments of to_html except for the "
r"argument 'buf' will be keyword-only."
)
with tm.assert_produces_warning(FutureWarning, match=msg):
df.to_html(None, None)

0 comments on commit 04f03fb

Please sign in to comment.