Skip to content

Commit

Permalink
Try skipna=True for new call-sites
Browse files Browse the repository at this point in the history
  • Loading branch information
h-vetinari committed Jan 3, 2019
1 parent e287bd8 commit 1ea21fe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pandas/core/arrays/array_.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def array(data, # type: Sequence[object]
return cls._from_sequence(data, dtype=dtype, copy=copy)

if dtype is None:
inferred_dtype = lib.infer_dtype(data, skipna=False)
inferred_dtype = lib.infer_dtype(data, skipna=True)
if inferred_dtype == 'period':
try:
return period_array(data, copy=copy)
Expand Down
4 changes: 2 additions & 2 deletions pandas/core/reshape/merge.py
Original file line number Diff line number Diff line change
Expand Up @@ -962,8 +962,8 @@ def _maybe_coerce_merge_keys(self):
# object values are allowed to be merged
elif ((lk_is_object and is_numeric_dtype(rk)) or
(is_numeric_dtype(lk) and rk_is_object)):
inferred_left = lib.infer_dtype(lk, skipna=False)
inferred_right = lib.infer_dtype(rk, skipna=False)
inferred_left = lib.infer_dtype(lk, skipna=True)
inferred_right = lib.infer_dtype(rk, skipna=True)
bool_types = ['integer', 'mixed-integer', 'boolean', 'empty']
string_types = ['string', 'unicode', 'mixed', 'bytes', 'empty']

Expand Down

0 comments on commit 1ea21fe

Please sign in to comment.