-
-
Notifications
You must be signed in to change notification settings - Fork 18k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MAINT: Clean up docs in pandas/errors/__init__.py
- Loading branch information
Showing
1 changed file
with
14 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66ec5f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback @jorisvandenbossche : Any idea why Travis is failing suddenly on such an innocuous commit:
https://travis-ci.org/pandas-dev/pandas/jobs/267760269#L1628
66ec5f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but it is in any case not related, and I have seen that failure yesterday on a PR as well, thinking that it did not really seem related to that PR.
BTW: I would like to propose that we as a general rule never push to master directly. Even for such small edits, it is very easy to just make a PR (not because this is one is now failing, as it is not related, but just as a general rule)
66ec5f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened an issue to track it: #17323
66ec5f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair. I only do it (rarely) on occasions when I'm 100% sure that my changes should not precipitate a failure (and if they do, then I'm pretty sure that there is a bug lying around somewhere, perhaps not even in
pandas
- I had a similar push that caught apyarrow
package issue onconda
for example).