Skip to content

Commit

Permalink
fix typing and tune tests for copy on write
Browse files Browse the repository at this point in the history
  • Loading branch information
lithomas1 committed Sep 14, 2024
1 parent 7a967fc commit 679e45e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
6 changes: 3 additions & 3 deletions pandas/io/gbq.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from pandas.util._exceptions import find_stack_level

if TYPE_CHECKING:
import google.auth
from google.auth.credentials import Credentials

from pandas import DataFrame

Expand All @@ -37,7 +37,7 @@ def read_gbq(
dialect: str | None = None,
location: str | None = None,
configuration: dict[str, Any] | None = None,
credentials: google.auth.credentials.Credentials | None = None,
credentials: Credentials | None = None,
use_bqstorage_api: bool | None = None,
max_results: int | None = None,
progress_bar_type: str | None = None,
Expand Down Expand Up @@ -230,7 +230,7 @@ def to_gbq(
table_schema: list[dict[str, str]] | None = None,
location: str | None = None,
progress_bar: bool = True,
credentials: google.auth.credentials.Credentials | None = None,
credentials: Credentials | None = None,
) -> None:
warnings.warn(
"to_gbq is deprecated and will be removed in a future version. "
Expand Down
5 changes: 4 additions & 1 deletion pandas/tests/io/test_parquet.py
Original file line number Diff line number Diff line change
Expand Up @@ -1315,7 +1315,10 @@ def test_empty_dataframe(self, fp):
check_round_trip(df, fp, expected=expected)

@pytest.mark.xfail(
reason="fastparquet bug, see https://github.com/dask/fastparquet/issues/929"
not using_copy_on_write()
and _HAVE_FASTPARQUET
and Version(fastparquet.__version__) > Version("2022.12"),
reason="fastparquet bug, see https://github.com/dask/fastparquet/issues/929",
)
def test_timezone_aware_index(self, fp, timezone_aware_date_list):
idx = 5 * [timezone_aware_date_list]
Expand Down

0 comments on commit 679e45e

Please sign in to comment.